Update to support UPM packages for glTF #631
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ms-RistoRK
requested review from
marlenaklein-msft,
AMollis,
shaynie and
a team
as code owners
AMollis
requested changes
Feb 2, 2024
ms-RistoRK
commented
Feb 3, 2024
AMollis
previously requested changes
Feb 3, 2024
There was a problem hiding this comment.
I would like @keveleigh to sign off on the changes, since they have more knowledge on this area.
keveleigh
reviewed
Feb 5, 2024
| We anticipate KTX package to be available within Unity by default in the future, after which we will add the dependency to the MRTK3 Input Package. |
There was a problem hiding this comment.
after which we will add the dependency to the MRTK3 Input Package.
Might be time to add it as an explicit dependency?
Update manifest.json
|
Abandoning this PR as we don't have the resources to exhaustively test on all devices where MRTK3 is deployed and the bandwidth issue with com.atteneder.ktx package is an accepted known issue. |
keveleigh
force-pushed
the
Bug630FixRemovingWrongPackageReferences
branch
from
3a7079f to
10acdc1
Compare
keveleigh
changed the title
keveleigh
force-pushed
the
Bug630FixRemovingWrongPackageReferences
branch
from
10acdc1 to
1c43b9b
Compare
Update ControllerModelLoader.cs Update ControllerModelLoader.cs
keveleigh
force-pushed
the
Bug630FixRemovingWrongPackageReferences
branch
2 times, most recently
from
9507104 to
8cb85ed
Compare
keveleigh
changed the title
keveleigh
force-pushed
the
Bug630FixRemovingWrongPackageReferences
branch
from
17d0ee4 to
95eaa95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #630
Fixes #883